Differential D19750

[attica] compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Mar 14 2019, 7:58 AM.

Details

Reviewers
dfaure
Commits
R235:5840e54feea0: [attica] compile without foreach
Summary

compile without foreach

Test Plan

autotest ok

Diff Detail

Repository
R235 Attica
Branch
compile_without_foreach (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9707
Build 9725: arc lint + arc unit
mlaurent created this revision.Mar 14 2019, 7:58 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 14 2019, 7:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Mar 14 2019, 7:58 AM
dfaure added a comment.Mar 16 2019, 11:39 PM

Everything else looks OK.

src/providermanager.cpp
106–107

the variable could be better named, like providerFiles or just files
(these are files, not providers)

mlaurent updated this revision to Diff 54075.Mar 17 2019, 10:52 AM

Rename variable

dfaure accepted this revision.Mar 17 2019, 7:56 PM
This revision is now accepted and ready to land.Mar 17 2019, 7:56 PM
Closed by commit R235:5840e54feea0: [attica] compile without foreach (authored by mlaurent). · Explain WhyMar 18 2019, 5:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 54075

View Options

CMakeLists.txt

Loading...
View Options

src/provider.cpp

Loading...
View Options

src/providermanager.cpp

Loading...
View Options

tests/projecttest/projecttest.cpp

Loading...