Differential D19728

[GridViewKCM] Fix implicit width calculation
ClosedPublic
Actions

Authored by broulik on Mar 13 2019, 2:50 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R296:72f438f8e7ad: [GridViewKCM] Fix implicit width calculation
Summary

Take into account paddings around the page and scroll view and also use the correct grid delegate size

Test Plan

Opened colors KCM, size was correct to the pixel now. Resized the window smaller a single pixel and it wrapped the delegates into two columns
Initial size before


Initial size after

It wasn't an issue with the KCMs with default width as the minimum width of the dialog (due to the button box at the bottom) was greater than three delegates worth

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 13 2019, 2:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 13 2019, 2:50 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Mar 13 2019, 2:50 PM
broulik edited the test plan for this revision. (Show Details)
mart accepted this revision.Mar 13 2019, 2:52 PM
This revision is now accepted and ready to land.Mar 13 2019, 2:52 PM
Closed by commit R296:72f438f8e7ad: [GridViewKCM] Fix implicit width calculation (authored by broulik). · Explain WhyMar 13 2019, 2:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53800

View Options

src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

Loading...