[Logout Screen] Show info that rebooting will enter firmware setup
ClosedPublic

Authored by broulik on Mar 6 2019, 10:51 AM.

Details

Summary

When the flag to reboot into BIOS/UEFI setup is set, show a hint on the logout screen.
For simplicity and to avoid the layout from shifting, and since the user had to explicitly enable the flag and probably know what they're doing, it is shown regardless of what action is highlighted.

Test Plan

See D19560

Suggestions on wording welcome

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 6 2019, 10:51 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2019, 10:51 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 6 2019, 10:51 AM
broulik updated this revision to Diff 53265.

Use "restarted" instead of rebooted, just saw that we use the former now :)

ngraham accepted this revision.Mar 6 2019, 3:16 PM
ngraham added a subscriber: ngraham.

The wording looks good to me!

This revision is now accepted and ready to land.Mar 6 2019, 3:16 PM
sitter added a subscriber: sitter.Mar 11 2019, 1:43 PM

I think it's bad practice to do blocking dbus calls.

broulik updated this revision to Diff 53654.Mar 11 2019, 1:51 PM
  • Async call

I think you lost the QML part of the diff.

LGTM, can't really comment on the qml side though. Haven't worked with qml in years.

broulik updated this revision to Diff 53660.Mar 11 2019, 2:53 PM
  • Restore QML
This revision was automatically updated to reflect the committed changes.