Fix XembedSNIProxy Logging Category Registration
ClosedPublic
Actions

Authored by davidedmundson on Jun 18 2016, 9:57 PM.

Details

Reviewers

Group Reviewers

Commits

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson retitled this revision from to Fix XembedSNIProxy Logging Category Registration.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

What was wrong with it? The old code looks correct to me as well. So what does this change "Fix"?

In D1953#36014, @graesslin wrote:

What was wrong with it? The old code looks correct to me as well. So what does this change "Fix"?

I had two Q_LOGGING_CATEGORY's

one made by the marco, one done by hand.

Then I was managing to not link the one in the macro. (two wrongs make a right)

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Jun 21 2016, 3:45 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			xembed-sni-proxy/CMakeLists.txt (9 lines)
M			xembed-sni-proxy/main.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4624	74056fb		Jun 18 2016, 9:57 PM	★	★
Diff 2	4825	9016eaa	rPLASMAWORKSPACE76c2f0dc0d16abcd09475d89d2b89fb7026f6c7f	Jun 28 2016, 8:44 PM	★	★