[kconf_update] move from custom logging tech to qCDebug

Authored by sitter on Mar 4 2019, 10:41 AM.



the previous logging tech got kind of defunct in 2014 (to the point where
it was basically qCDebug). seeing as no one really complained it seems
reasonable to just move to qCDebug instead and make use of category filters
and other qdebug goodness (such as system logging facilities for the
various platforms)

  • new logging category kf5.kconfig.update; at info level by default (i.e. unless otherwise configured kconf_update is now silent)
  • --debug cmdline option now also attempts to force-enable the debug mode on that category (and debugs that attempt in of itself, so we don't get confused by categories magically getting enabled).
  • all log() calls are now qCDebug calls
  • all logFileErorr() calls (which was context-sensitive to the .upd file parsing) have been changed to qCDebugFile
  • qCDebugFile is a new *macro* wrapping around qCDebug to give it file context
  • everything is now qCDebug instead of qDebug
  • arguments updated to drop excess quoting and spaces to reduce "noise"


Test Plan

updater still works and debugs when debug is enabled

Diff Detail

R237 KConfig
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 4 2019, 10:41 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 4 2019, 10:41 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Mar 4 2019, 10:41 AM
apol added a comment.Mar 4 2019, 1:16 PM

+1 makes sense to me

aacid added a comment.Mar 4 2019, 11:29 PM

Don't see anything obviously wrong, but i personally don't feel like i have enough knowledge on the file to say "yep go ahead and commit", but maybe noone feels like that so i'd say if after one or two weeks noone does, do a quick ping and the commit :D

This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2019, 1:48 PM
This revision was automatically updated to reflect the committed changes.