Differential D1940

[Recent Documents Runner] Add drag and drop, "show in folder" action and subtext
ClosedPublic
Actions

Authored by broulik on Jun 17 2016, 10:33 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma: Design
Plasma
Commits
R871:1d26ef82c74e: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext
R120:1d26ef82c74e: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext
Summary

This adds the ability to drag a recent document elsewhere to eg. create an icon widget or sticky note, the ability to show the file in its folder using the new OpenFileManagerWindowJob as well as a subtext showing the path to the file

Test Plan

Work

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 4598.Jun 17 2016, 10:33 PM
broulik retitled this revision from to [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 17 2016, 10:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
colomar added a subscriber: colomar.Jun 18 2016, 2:43 PM

Great change, +1 to all the features!

Just a question: What does dragging to a sticky note do?

broulik added a comment.Jun 18 2016, 3:23 PM

If you drag it to an existing sticky note you'll paste the path to the file. I decided against pasting the file contents in this case back when I implemented this. This is in the notes applet and affects any drag and drop operation to it, not just for this runner.

If you drag a text file to the desktop, it'll create a sticky note with the file's contents.

colomar added a comment.Jun 18 2016, 4:36 PM
In D1940#35859, @broulik wrote:

If you drag it to an existing sticky note you'll paste the path to the file. I decided against pasting the file contents in this case back when I implemented this. This is in the notes applet and affects any drag and drop operation to it, not just for this runner.

If you drag a text file to the desktop, it'll create a sticky note with the file's contents.

Makes sense, all fine from my perspective then!

davidedmundson accepted this revision.Jun 18 2016, 6:55 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jun 18 2016, 6:55 PM
Closed by commit R120:1d26ef82c74e: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext (authored by broulik). · Explain WhyJun 18 2016, 7:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4598

View Options

runners/recentdocuments/recentdocuments.h

Loading...
View Options

runners/recentdocuments/recentdocuments.cpp

Loading...