the previous code would construct file:// URIs. instead, leave the url
construction to kpackage so we get either file:// or qrc:// depending on
the actual type of the package
Details
Details
- cmake pass
- make pass
- make test pass
Diff Detail
Diff Detail
- Repository
- R296 KDeclarative
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Makes sense, it would make sense to see if we can come up with a check for such things. I wonder if filePath should be deprecated actually as it's better dealt by the host application.
Comment Actions
LXR seems to show a whole bunch of these code segments https://lxr.kde.org/search?_filestring=&_string=package.filePath
Deprecation is probably a good idea. From where I am standing an application can always grab the path out of an url if absolutely necessary.