Cleanup use of TasksModel data roles.
ClosedPublic

Authored by hein on Jun 17 2016, 9:50 AM.

Details

Summary

Avoid a wall of prop rebindings to access roles outside the delegates
causing unnecessary calls to data().

Be 'typesafe' about testing against true. If a role returns QVariant(),
just binding it to e.g. a 'visible' prop still evaluates to true
incorrectly otherwise.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein updated this revision to Diff 4583.Jun 17 2016, 9:50 AM
hein retitled this revision from to Cleanup use of TasksModel data roles..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added reviewers: broulik, dfaure.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 17 2016, 9:50 AM
hein updated this revision to Diff 4586.Jun 17 2016, 10:20 AM

Fix ReferenceErrors from dumb mistake.

hein added a comment.Jun 17 2016, 10:32 AM

[19:30] <kbroulik_> Sho_: sorry it's impossible ot review with that internet connection :/
[19:30] <kbroulik_> Sho_: https://phabricator.kde.org/D1934 ← make it readonly property var m and then ship it

This revision was automatically updated to reflect the committed changes.