[DeviceNotifier] Port settings to QQC2 and Kirigami
ClosedPublic

Authored by filipf on Sun, Feb 24, 9:48 PM.

Details

Summary

Settings are ported to QtQuickControls 2 and now use a Kirigami Form Layout.

Test Plan

Before:


After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Sun, Feb 24, 9:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Feb 24, 9:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Sun, Feb 24, 9:48 PM
filipf edited the test plan for this revision. (Show Details)Sun, Feb 24, 9:49 PM
filipf added reviewers: VDG, Plasma, ngraham.
davidedmundson accepted this revision.Sun, Feb 24, 9:54 PM
This revision is now accepted and ready to land.Sun, Feb 24, 9:54 PM
ngraham accepted this revision.Sun, Feb 24, 10:02 PM

Nice work!

Out of curiosity, did you need the exclusive group.
In theory RadioButton should do it automatically when we share a parent, I'm curious if FormLayout breaks that.

filipf updated this revision to Diff 52493.Sun, Feb 24, 10:29 PM

ButtonGroup is not needed

Out of curiosity, did you need the exclusive group.
In theory RadioButton should do it automatically when we share a parent, I'm curious if FormLayout breaks that.

You're right, it wasn't necessary; I was following the original code too closely.

filipf added inline comments.Sun, Feb 24, 10:32 PM
applets/devicenotifier/package/contents/ui/configGeneral.qml
19–20

Is PlasmaCore also needed here?

ngraham added inline comments.Sun, Feb 24, 10:34 PM
applets/devicenotifier/package/contents/ui/configGeneral.qml
19–20

Looks like it's not used anywhere, so I'd say no.

filipf updated this revision to Diff 52497.Sun, Feb 24, 10:47 PM

remove PlasmaCore as an import

filipf marked 2 inline comments as done.Sun, Feb 24, 10:47 PM
This revision was automatically updated to reflect the committed changes.