create-abi-dump/check-abi: implement new accMetadata.

Authored by knauss on Feb 22 2019, 12:01 PM.

Diff Detail

R857 CI System Tooling
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
knauss requested review of this revision.Feb 22 2019, 12:01 PM
knauss created this revision.

Sorry, what issue does this solve exactly?

Sorry, what issue does this solve exactly?

right, that is unclear. This solves the issue, that currently we use the cmake package name as library name. In most cases this is the same, so I havn't recogniced, that this differs. But e.g. @kossebau (T10504) renamed the library without renaming the cmake package that''s why our SONAME detection doesn't work. The new accMetadataVersion fixes this. Additionally it also adds the SONAME per library. This will be become handy for Akonadi, as inside the one cmakePackage Akonadi there are multiple libraries, that may have different SONAME.

To not break the current ABI checks, I fixed check-abi to work with the old and new accMetadata. This can be cleaned up within one or two months.

bcooksley accepted this revision.Feb 25 2019, 9:00 AM

Thanks for that detail. I'm going to update the commit message when landing this, but otherwise it looks fine.

This revision is now accepted and ready to land.Feb 25 2019, 9:00 AM
This revision was automatically updated to reflect the committed changes.