Details
- Reviewers
bcooksley - Maniphest Tasks
- T3689: Add abi compliance checker to CI
- Commits
- R857:711259ce58de: Change from using the CMake package name to using the library name instead.
Diff Detail
- Repository
- R857 CI System Tooling
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 8680 Build 8698: arc lint + arc unit
right, that is unclear. This solves the issue, that currently we use the cmake package name as library name. In most cases this is the same, so I havn't recogniced, that this differs. But e.g. @kossebau (T10504) renamed the library without renaming the cmake package that''s why our SONAME detection doesn't work. The new accMetadataVersion fixes this. Additionally it also adds the SONAME per library. This will be become handy for Akonadi, as inside the one cmakePackage Akonadi there are multiple libraries, that may have different SONAME.
To not break the current ABI checks, I fixed check-abi to work with the old and new accMetadata. This can be cleaned up within one or two months.
Thanks for that detail. I'm going to update the commit message when landing this, but otherwise it looks fine.