Differential D19189

[KMail] Add an option to start in tray
ClosedPublic
Actions

Authored by matthieugras on Feb 20 2019, 4:07 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM: KMail
Commits
R206:bf081dae2354: [KMail] Add an option to start in tray
Summary

Adds an option to launch Kmail minimized to tray

Diff Detail

Repository
R206 KMail
Branch
local
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8641
Build 8659: arc lint + arc unit
matthieugras created this revision.Feb 20 2019, 4:07 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 20 2019, 4:07 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
matthieugras requested review of this revision.Feb 20 2019, 4:07 PM
dvratil added a subscriber: dvratil.Feb 21 2019, 9:38 AM

Looks good, should it maybe be a configuration option in KMail settings window as well?

matthieugras added a comment.Feb 21 2019, 12:30 PM
In D19189#416509, @dvratil wrote:

Looks good, should it maybe be a configuration option in KMail settings window as well?

Yes, good idea, I will add it today

matthieugras updated this revision to Diff 52213.Feb 21 2019, 3:28 PM
mlaurent requested changes to this revision.Feb 21 2019, 5:43 PM
mlaurent added inline comments.
src/configuredialog/configureappearancepage.cpp
903

Please merge two signal :
connect(mStartInTrayCheck, &QCheckBox::stateChanged,

this, &ConfigModuleTab::slotEmitChanged);

and this one in one slot.
Not necessary to have 2 connections

907

same

This revision now requires changes to proceed.Feb 21 2019, 5:43 PM
matthieugras updated this revision to Diff 52224.Feb 21 2019, 5:58 PM

Merging connects

mlaurent added inline comments.Feb 22 2019, 12:04 PM
src/configuredialog/configureappearancepage.cpp
887

"this->" is necessary ?

matthieugras updated this revision to Diff 52288.Feb 22 2019, 12:09 PM
matthieugras marked 2 inline comments as done.

remove "this"

mlaurent accepted this revision.Feb 22 2019, 12:33 PM

thanks:)

This revision is now accepted and ready to land.Feb 22 2019, 12:33 PM
lbeltrame added a subscriber: lbeltrame.Feb 25 2019, 1:32 PM

@matthieugras Do you have a commit access? Or do you need a developer to push this for you?

matthieugras added a comment.Feb 25 2019, 8:11 PM
In D19189#419282, @lbeltrame wrote:

@matthieugras Do you have a commit access? Or do you need a developer to push this for you?

No, I do not

Closed by commit R206:bf081dae2354: [KMail] Add an option to start in tray (authored by matthieugras, committed by dvratil). · Explain WhyFeb 25 2019, 10:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52224

View Options

src/configuredialog/configureappearancepage.h

Loading...
View Options

src/configuredialog/configureappearancepage.cpp

Loading...
View Options

src/kmail_options.h

Loading...
View Options

src/kmkernel.h

Loading...
View Options

src/kmkernel.cpp

Loading...
View Options

src/settings/kmail.kcfg.cmake

Loading...