[KMail] Add an option to start in tray
ClosedPublic

Authored by matthieugras on Feb 20 2019, 4:07 PM.

Details

Summary

Adds an option to launch Kmail minimized to tray

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
matthieugras created this revision.Feb 20 2019, 4:07 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 20 2019, 4:07 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
matthieugras requested review of this revision.Feb 20 2019, 4:07 PM

Looks good, should it maybe be a configuration option in KMail settings window as well?

Looks good, should it maybe be a configuration option in KMail settings window as well?

Yes, good idea, I will add it today

mlaurent requested changes to this revision.Feb 21 2019, 5:43 PM
mlaurent added inline comments.
src/configuredialog/configureappearancepage.cpp
903

Please merge two signal :
connect(mStartInTrayCheck, &QCheckBox::stateChanged,

this, &ConfigModuleTab::slotEmitChanged);

and this one in one slot.
Not necessary to have 2 connections

907

same

This revision now requires changes to proceed.Feb 21 2019, 5:43 PM

Merging connects

mlaurent added inline comments.Feb 22 2019, 12:04 PM
src/configuredialog/configureappearancepage.cpp
887

"this->" is necessary ?

matthieugras marked 2 inline comments as done.

remove "this"

mlaurent accepted this revision.Feb 22 2019, 12:33 PM

thanks:)

This revision is now accepted and ready to land.Feb 22 2019, 12:33 PM

@matthieugras Do you have a commit access? Or do you need a developer to push this for you?

@matthieugras Do you have a commit access? Or do you need a developer to push this for you?

No, I do not

This revision was automatically updated to reflect the committed changes.