Differential D19125

Change shadow color to 0,0,0 for KStyle
ClosedPublic
Actions

Authored by ndavis on Feb 18 2019, 7:05 PM.

Details

Reviewers
ngraham
zzag
Group Reviewers
VDG
Breeze
Commits
R31:3e78fa28585e: Change shadow color to 0,0,0 for KStyle
Summary

Continuation of D19124

Diff Detail

Repository
R31 Breeze
Branch
black-shadow (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8495
Build 8513: arc lint + arc unit
ndavis created this revision.Feb 18 2019, 7:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2019, 7:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Feb 18 2019, 7:05 PM
ngraham accepted this revision.Feb 18 2019, 7:05 PM
ngraham added a reviewer: zzag.
This revision is now accepted and ready to land.Feb 18 2019, 7:05 PM
zzag added a comment.Feb 18 2019, 7:15 PM

Should we adjust opacity as well?

ndavis added a comment.Feb 18 2019, 7:18 PM
In D19125#414786, @zzag wrote:

Should we adjust opacity as well?

That's the strength value, right? I don't think so.

ngraham added a comment.Feb 18 2019, 7:18 PM

Nah, I think that would begin to re-introduce the bug we're trying to solve (shadows not being visible in Breeze Dark).

ndavis added a comment.Feb 18 2019, 7:19 PM
In D19125#414788, @ngraham wrote:

Nah, I think that would begin to re-introduce the bug we're trying to solve (shadows not being visible in Breeze Dark).

Also, worse color banding on cheap displays

zzag accepted this revision.Feb 18 2019, 7:23 PM
Closed by commit R31:3e78fa28585e: Change shadow color to 0,0,0 for KStyle (authored by ndavis). · Explain WhyFeb 18 2019, 7:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstyle/breeze.kcfg (2 lines)

Diff 51995

View Options

kstyle/breeze.kcfg

Loading...