Fix crash during shutdown
AbandonedPublic

Authored by hallas on Feb 18 2019, 8:02 AM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Summary

Fix crash during shutdown. The root cause is that when Dolphin in stopped as
part of an activity, the KItemListViewAccessible destructor is called after
QApplication::exec has returned causing Qt to already having cleaned up the
QAccessibleInterface instances kept in KItemListViewAccessible. Instead of
storing the pointers to QAccessibleInterface we store the QAccessible::Id so
that we can use the QAccessible::deleteAccessibleInterface function for
deleting the instances.

BUG: 402784

Test Plan

I wasn't able to reproduce the crash in the first place, but I have just
opened and closed Dolphin a few times and verified the the QAccessibleInterface
instances are correctly cleaned up.

Diff Detail

Repository
R318 Dolphin
Branch
Applications/18.12
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8468
Build 8486: arc lint + arc unit
hallas requested review of this revision.Feb 18 2019, 8:02 AM
hallas created this revision.
hallas abandoned this revision.Feb 18 2019, 7:22 PM

No need for a separate diff, the fix is in D19083