Differential D19056

Tell people they should mostly be using KF5::AuthCore
ClosedPublic
Actions

Authored by aacid on Feb 15 2019, 9:34 PM.

Details

Reviewers
apol
Commits
R283:1e3b43bfa0f3: Tell people they should mostly be using KF5::AuthCore

Diff Detail

Repository
R283 KAuth
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Feb 15 2019, 9:34 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 15 2019, 9:34 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Feb 15 2019, 9:34 PM
cfeck retitled this revision from Tell people they should mostly be using KF5::Auth to Tell people they should mostly be using KF5::AuthCore.Feb 15 2019, 9:38 PM
apol added a subscriber: apol.Feb 16 2019, 12:43 AM

Suggestion:

or find KF5 with the Auth component in your CMakeLists.txt file. You need
to link to KF5::AuthCore, or KF5::Auth if you need KAuth::ObjectDecorator.
README.md
16–17

we could change the , and for a full stop so it's not a super long sentence?

17–18

I'd drop the parenthesis.

aacid updated this revision to Diff 51840.Feb 16 2019, 9:35 AM

Wording improvements suggested by Aleix

apol accepted this revision.Feb 18 2019, 10:34 PM
This revision is now accepted and ready to land.Feb 18 2019, 10:34 PM
Closed by commit R283:1e3b43bfa0f3: Tell people they should mostly be using KF5::AuthCore (authored by aacid). · Explain WhyFeb 18 2019, 10:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MREADME.md (4 lines)

Diff 52019

View Options

README.md

Loading...