Make "Save Session" action ask for a name for anonymous sessions
ClosedPublic

Authored by ahmadsamir on Feb 14 2019, 5:32 PM.

Details

Summary

When invoking "Save Session", kate should ask for a session name if
the session is anonymous, i.e. the same behaviour when using saving a
a new file/unnamed document.

BUG: 319396
FIXED-IN: 19.04.0

Test Plan

Opening a kate instance with a new/anonymous session and invoking
"Save Session" should ask the user to enter a name for the session.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Feb 14 2019, 5:32 PM
Restricted Application added a project: Kate. · View Herald TranscriptFeb 14 2019, 5:32 PM
ahmadsamir requested review of this revision.Feb 14 2019, 5:32 PM

From the referenced bug report this comment is talking about unnamed sessions getting saved in a way to allow configuring plugins and view layouts for such sessions... I looked at bug 156330, and this diff doesn't break the fix from the latter report; unless there's something I didn't understand.

ngraham edited the summary of this revision. (Show Details)Feb 14 2019, 7:07 PM

+1 works great!

cullmann accepted this revision.Mar 2 2019, 3:12 PM

Should be safe to change, I didn't use that way to save my plugin changes since long.

This revision is now accepted and ready to land.Mar 2 2019, 3:12 PM
This revision was automatically updated to reflect the committed changes.

Could you explain how you now configure the default session or how new sessions look like?