Differential D1891

[Holiday Events] Handle holidays spanning multiple days
ClosedPublic
Actions

Authored by broulik on Jun 15 2016, 2:11 PM.

Details

Reviewers
davidedmundson
mck182
graesslin
Group Reviewers
Plasma
Commits
R871:7ab1f6d33b6a: [Holiday Events] Handle holidays spanning multiple days
R120:7ab1f6d33b6a: [Holiday Events] Handle holidays spanning multiple days
Summary

We are told the start and end date but we didn't actually add the event to the other days.

BUG: 364345

Test Plan

Doesn't look too right to me but works :)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4509.Jun 15 2016, 2:11 PM
broulik retitled this revision from to [Holiday Events] Handle holidays spanning multiple days.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, graesslin, mck182.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 15 2016, 2:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a comment.Jun 15 2016, 2:12 PM

Easter Monday shown

broulik updated this object.Jun 15 2016, 2:14 PM
graesslin accepted this revision.Jun 15 2016, 2:23 PM
graesslin edited edge metadata.

looks good to me, but maybe wait for @mck182 to comment.

This revision is now accepted and ready to land.Jun 15 2016, 2:23 PM
davidedmundson accepted this revision.Jun 16 2016, 9:31 AM
davidedmundson added a reviewer: davidedmundson.
Closed by commit R120:7ab1f6d33b6a: [Holiday Events] Handle holidays spanning multiple days (authored by broulik). · Explain WhyJun 16 2016, 9:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4543

View Options

plasmacalendarintegration/holidaysevents.cpp

Loading...