Differential D18919

Define QT.phonon4qt5.module = phonon4qt5 for Qt5-5.12.1
ClosedPublic
Actions

Authored by tcberner on Feb 11 2019, 6:20 AM.

Details

Reviewers
sitter
Group Reviewers
FreeBSD
Restricted Owners Package(Owns No Changed Paths)
Commits
R487:b46c224553f6: Define QT.phonon4qt5.module = phonon4qt5 for Qt5-5.12.1
R487:2c8b6362ff91: Revert "Port some code to for(...:...)"
Summary

I think [1] broke the qt5_phonon.pri file [2] -- the library is no
longer added to the linker arguments.

[1] https://github.com/qt/qtbase/commit/e0926ca4260953a70cdb2a6f84da35517ead1349#diff-4b36b0980a641d6a8d8e640f89c45625
[2] http://package22.nyi.freebsd.org/data/112amd64-default-PR235620PR235622/2019-02-09_20h17m10s/logs/auralquiz-1.0.0_2.log

Diff Detail

Repository
R487 Phonon
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8146
Build 8164: arc lint + arc unit
tcberner created this revision.Feb 11 2019, 6:20 AM
Owners added a reviewer: Restricted Owners Package.Feb 11 2019, 6:20 AM
tcberner requested review of this revision.Feb 11 2019, 6:20 AM
sitter added a comment.Feb 11 2019, 8:24 AM

Probably should set module like in https://phabricator.kde.org/D18243

tcberner added a comment.Feb 11 2019, 4:19 PM
In D18919#409765, @sitter wrote:

Probably should set module like in https://phabricator.kde.org/D18243

Do you mean using that ecm macro?

sitter accepted this revision.Feb 12 2019, 10:34 AM

No, what I meant was do it like the other diff. Though now I realize that I might be going mad as they are doing the same thing... perhaps I was reviewing while still asleep.

The diff looks perfect.

This revision is now accepted and ready to land.Feb 12 2019, 10:34 AM
Closed by commit R487:b46c224553f6: Define QT.phonon4qt5.module = phonon4qt5 for Qt5-5.12.1 (authored by tcberner). · Explain WhyFeb 12 2019, 11:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mqt5_phonon.pri (1 line)

Diff 51390

View Options

qt5_phonon.pri

Loading...