[kcms/mouse] Load current server settings in kcminit

Authored by davidedmundson on Feb 6 2019, 1:14 AM.



Without loading the current server status m_handed will remain

EvdevSettings::load relies on various properties of X11EvdevBackend to
be initialised properly. When we load the settings from the config it'll
then save the fact that the server doesn't support setting which hand mouse to use as none was loaded - and assume that means we probably can't apply any setting.

BUG: 395401

Test Plan

Ran in virtualbox (to get evdev used)
kcminit_startup was going into the right codepaths

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Feb 6 2019, 1:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 6 2019, 1:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 6 2019, 1:14 AM
davidedmundson edited the summary of this revision. (Show Details)Feb 6 2019, 1:15 AM
ngraham added a subscriber: ngraham.Feb 6 2019, 1:27 AM

Hmm, this does not compile for me:

[ 34%] Building CXX object kcms/mouse/CMakeFiles/kcm_mouse.dir/backends/x11/x11_evdev_backend.cpp.o
/home/dev/repos/plasma-desktop/kcms/mouse/backends/x11/x11_evdev_backend.cpp: In member function ‘virtual void X11EvdevBackend::kcmInit()’:
/home/dev/repos/plasma-desktop/kcms/mouse/backends/x11/x11_evdev_backend.cpp:276:5: error: invalid use of non-static member function ‘virtual void X11EvdevBackend::load()’
/home/dev/repos/plasma-desktop/kcms/mouse/backends/x11/x11_evdev_backend.cpp:112:6: note: declared here
 void X11EvdevBackend::load()

Does this have a dependency that hasn't been submitted yet? I did notice that arc complained that the diff was based on a commit not in my repo.

fix copy pasta out of virtualbox

ngraham accepted this revision.Feb 6 2019, 3:10 AM

Lovely. Confirmed the fix. Such a small change for a big problem. Do you think you could land this on the Plasma/5.14 branch and then merge forward? There are rumblings of a new 5.14 release and it would be nice to get this in there too along with the Discover and Folder view fixes. especially since Debian is going to freeze on 5.14 and otherwise we'll hear complaints about this for the next 5 years. :)

This revision is now accepted and ready to land.Feb 6 2019, 3:10 AM
mart accepted this revision.Feb 6 2019, 9:13 AM
This revision was automatically updated to reflect the committed changes.