| ngraham | |
| mart |
| Plasma |
Without loading the current server status m_handed will remain
Handed::NotSupported;
EvdevSettings::load relies on various properties of X11EvdevBackend to
be initialised properly. When we load the settings from the config it'll
then save the fact that the server doesn't support setting which hand mouse to use as none was loaded - and assume that means we probably can't apply any setting.
BUG: 395401
Ran in virtualbox (to get evdev used)
kcminit_startup was going into the right codepaths
| No Linters Available |
| No Unit Test Coverage |
| Buildable 7939 | |
| Build 7957: arc lint + arc unit |
Hmm, this does not compile for me:
[ 34%] Building CXX object kcms/mouse/CMakeFiles/kcm_mouse.dir/backends/x11/x11_evdev_backend.cpp.o
/home/dev/repos/plasma-desktop/kcms/mouse/backends/x11/x11_evdev_backend.cpp: In member function ‘virtual void X11EvdevBackend::kcmInit()’:
/home/dev/repos/plasma-desktop/kcms/mouse/backends/x11/x11_evdev_backend.cpp:276:5: error: invalid use of non-static member function ‘virtual void X11EvdevBackend::load()’
load;
^~~~
/home/dev/repos/plasma-desktop/kcms/mouse/backends/x11/x11_evdev_backend.cpp:112:6: note: declared here
void X11EvdevBackend::load()
^~~~~~~~~~~~~~~Does this have a dependency that hasn't been submitted yet? I did notice that arc complained that the diff was based on a commit not in my repo.
Lovely. Confirmed the fix. Such a small change for a big problem. Do you think you could land this on the Plasma/5.14 branch and then merge forward? There are rumblings of a new 5.14 release and it would be nice to get this in there too along with the Discover and Folder view fixes. especially since Debian is going to freeze on 5.14 and otherwise we'll hear complaints about this for the next 5 years. :)