Differential D18774

Move lanczos filter away from KWin core
ClosedPublic
Actions

Authored by zzag on Feb 5 2019, 11:18 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R108:be8729105f62: Move lanczos filter away from KWin core

Summary

Lanczos filter shouldn't be in KWin core because it's quite specific about
rendering backend.

Test Plan

Windows in the desktop grid look normal.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.Feb 5 2019, 11:18 PM

Restricted Application added a project: KWin. · View Herald TranscriptFeb 5 2019, 11:18 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Feb 5 2019, 11:18 PM

Harbormaster completed remote builds in B7934: Diff 51001.Feb 5 2019, 11:18 PM

+1 (speaking of lanczos filer, sometimes thumbnails rendered with it seem to be invisible, ca you reproduce that?)

In D18774#406359, @mart wrote:

speaking of lanczos filer, sometimes thumbnails rendered with it seem to be invisible, ca you reproduce that?

Nope, I can't. Are you talking about thumbnails in the desktop grid?

In D18774#406361, @zzag wrote:

In D18774#406359, @mart wrote:

speaking of lanczos filer, sometimes thumbnails rendered with it seem to be invisible, ca you reproduce that?

Nope, I can't. Are you talking about thumbnails in the desktop grid?

yes, that's the place where sometimes i don't get thumbnails painted if the filter is used

davidedmundson accepted this revision.Feb 7 2019, 3:18 PM

This revision is now accepted and ready to land.Feb 7 2019, 3:18 PM

Closed by commit R108:be8729105f62: Move lanczos filter away from KWin core (authored by zzag). · Explain WhyFeb 7 2019, 4:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (3 lines)
V			{ → plugins/scenes/opengl}/lanczosfilter.h
V			{ → plugins/scenes/opengl}/lanczosfilter.cpp
M			plugins/scenes/opengl/CMakeLists.txt (9 lines)
V			{plugins/scenes/opengl ← }/lanczosfilter.h (6 lines)
V			{plugins/scenes/opengl ← }/lanczosfilter.cpp (12 lines)
V			{plugins/scenes/opengl ← }/resources.qrc (5 lines)
V			{plugins/scenes/opengl ← }/shaders/1.10/lanczos-fragment.glsl
V			{plugins/scenes/opengl ← }/shaders/1.40/lanczos-fragment.glsl
V			{ → plugins/scenes/opengl}/resources.qrc
V			{ → plugins/scenes/opengl}/shaders/1.10/lanczos-fragment.glsl
V			{ → plugins/scenes/opengl}/shaders/1.40/lanczos-fragment.glsl

Diff 51109

CMakeLists.txt

Loading...

lanczosfilter.h

Loading...

lanczosfilter.cpp

Loading...

plugins/scenes/opengl/CMakeLists.txt

Loading...

plugins/scenes/opengl/lanczosfilter.h

Loading...

plugins/scenes/opengl/lanczosfilter.cpp

Loading...

plugins/scenes/opengl/resources.qrc

Loading...

plugins/scenes/opengl/shaders/1.10/lanczos-fragment.glsl

Loading...

plugins/scenes/opengl/shaders/1.40/lanczos-fragment.glsl

Loading...

resources.qrc

Loading...

shaders/1.10/lanczos-fragment.glsl

Loading...

shaders/1.40/lanczos-fragment.glsl

Loading...