Rework the Quick Open Widget

Authored by tcanabrava on Jun 14 2016, 1:56 PM.



The Quick Open Widget had too much boilerplate code
and it also had incorrect behavior regarding utilization
of widgets - it always tried to delete / recreate a widget
instead of reusing one.

This series of patches tries to simplify the code and it also
fix a bug where the click of the mouse on top of the popup
actually closed the popup.

Test Plan

manually tested - the biggest bug is fixed.

Diff Detail

R33 KDevPlatform
No Linters Available
No Unit Test Coverage
tcanabrava updated this revision to Diff 4461.Jun 14 2016, 1:56 PM
tcanabrava retitled this revision from to Rework the Quick Open Widget.
tcanabrava edited the test plan for this revision. (Show Details)
tcanabrava added reviewers: apol, kfunk.
tcanabrava updated this object.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 14 2016, 1:56 PM
tcanabrava updated this revision to Diff 4498.Jun 15 2016, 11:05 AM
  • Use lambda for prev / next functions.
  • Simplify creation of the model and data items.
  • foreach > for
  • The bug still existed with that code, so nothing was fixed.
  • Update the model when showing the update.
  • Simplify Code
  • Remember to call the parent QKeyEvent
  • Fix crash
  • Don't try to set anything when we don't have m
arichardson added inline comments.

Use new connect syntax?

tcanabrava updated this revision to Diff 4547.Jun 16 2016, 11:34 AM
  • Use new signal style.
kfunk edited edge metadata.Jun 16 2016, 6:33 PM

Heya, checked your patch:

  • testing your patch. first observation: ctrl+alt+o opens a dialog now
  • second: ctrl+alt+o + esc doesn't give back focus to the editor
  • third: crash on exit:
kfunk requested changes to this revision.Jun 16 2016, 10:59 PM
kfunk edited edge metadata.
This revision now requires changes to proceed.Jun 16 2016, 10:59 PM
tcanabrava abandoned this revision.Jan 16 2017, 9:40 AM

no longer applies.