Differential D18706

[kcmkwin] Simplify EffectModel::save
ClosedPublic
Actions

Authored by zzag on Feb 3 2019, 5:04 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R108:7a28a7442ecd: [kcmkwin] Simplify EffectModel::save

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.Feb 3 2019, 5:04 PM

Restricted Application added a project: KWin. · View Herald TranscriptFeb 3 2019, 5:04 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Feb 3 2019, 5:04 PM

Harbormaster completed remote builds in B7820: Diff 50786.Feb 3 2019, 5:04 PM

zzag added a dependency: D18705: [kcmkwin] Don't discard unsaved changes when reloading effects model.Feb 3 2019, 8:20 PM

zzag added a dependent revision: D18707: [kcmkwin] Remove some name duplication in EffectModel.

Check whether interface is valid.

Harbormaster completed remote builds in B7857: Diff 50839.Feb 4 2019, 1:08 PM

Rebase.

Harbormaster completed remote builds in B7884: Diff 50889.Feb 4 2019, 9:15 PM

davidedmundson accepted this revision.Feb 5 2019, 9:53 AM

This revision is now accepted and ready to land.Feb 5 2019, 9:53 AM

zzag mentioned this in D18705: [kcmkwin] Don't discard unsaved changes when reloading effects model.Feb 21 2019, 1:10 PM

Rebase on top of 18705

Harbormaster completed remote builds in B8628: Diff 52205.Feb 21 2019, 1:20 PM

Closed by commit R108:7a28a7442ecd: [kcmkwin] Simplify EffectModel::save (authored by zzag). · Explain WhyMar 18 2019, 11:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kcmkwin/common/effectmodel.h (2 lines)
M			kcmkwin/common/effectmodel.cpp (50 lines)

Diff 54199

kcmkwin/common/effectmodel.h

Loading...

kcmkwin/common/effectmodel.cpp

Loading...