Differential D1866

Use QVector and QLatin1String, and range-based for
ClosedPublic
Actions

Authored by sebas on Jun 14 2016, 12:40 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R110:2792f55ff5c2: Use QVector and QLatin1String, and range-based for
Summary

This moves the code to the right string types and uses the C++11
toolbox, instead of Qt macros.

Diff Detail

Repository
R110 KScreen Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sebas updated this revision to Diff 4453.Jun 14 2016, 12:40 PM
sebas retitled this revision from to Use QVector and QLatin1String, and range-based for.
sebas updated this object.
sebas edited the test plan for this revision. (Show Details)
sebas added a reviewer: Plasma.
sebas added subscribers: graesslin, broulik.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 14 2016, 12:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a subscriber: apol.Jun 14 2016, 1:07 PM
apol added inline comments.
backends/xrandr/xrandroutput.cpp
258 ↗(On Diff #4453)

This one is fine, but I wouldn't change from foreach -> for as a norm, as it can easily backfire.

graesslin accepted this revision.Jun 14 2016, 1:48 PM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Jun 14 2016, 1:48 PM
Closed by commit R110:2792f55ff5c2: Use QVector and QLatin1String, and range-based for (authored by sebas). · Explain WhyJun 14 2016, 1:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mbackends/xrandr/xrandroutput.cpp (10 lines)

Diff 4460

View Options

backends/xrandr/xrandroutput.cpp

Loading...