...and add logic to "Spelling.." and "Spelling (from cursor)" actions
when there is a selection.
This way the behavior fit to other actions where the selection as
precedence over some default target and we have one entry less in menus.
Details
Details
- Reviewers
cullmann - Group Reviewers
KTextEditor - Commits
- R39:f2e7a22be5e5: KateSpellCheckDialog: Remove action "Spellcheck Selection"
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
For my taste could be "Spelling (from cursor)" the only offered action (logic). Always to check from the start is rarely useful, but I guess no one like that idea.
The current patch should cause no harm, except that someone need to reassign some shortcut or added tool bar button.
Comment Actions
In general I am ok eith this. Although it's a tiny bit less transparent to the user.
| src/spellcheck/spellcheckdialog.cpp | ||
|---|---|---|
| 74–78 | I don't like the fact that the function says "spellcheckFromCursor, and then internally does something different. Can this be improved by having the logic somewhere else? | |
Comment Actions
;=) given ::spellcheck() has the same magic, I don't think we really need to rename the function.
And spellcheckSelectionOrFromCursor is a bit strange, too.