Differential D18637

Update some files to QQC2 and fix minor bug
ClosedPublic
Actions

Authored by ognarb on Feb 1 2019, 12:40 AM.

Details

Reviewers
ngraham
Group Reviewers
Okular
Commits
R223:2d568acd7d5f: Update some files to QQC2 and fix minor bug
Summary

The bug was that the Drawer use the drawerOpen properties now instead of just open. And fix deprecation Kirigami.Label -> QQC2.Label.

Test Plan

Tested on my computer with the touchpad. I could potentialy try with my android phone, if needed.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Feb 1 2019, 12:40 AM
Restricted Application added a project: Okular. · View Herald TranscriptFeb 1 2019, 12:40 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
ognarb requested review of this revision.Feb 1 2019, 12:40 AM
ognarb edited the summary of this revision. (Show Details)Feb 1 2019, 12:41 AM
ognarb added a reviewer: Okular.
ngraham requested changes to this revision.Feb 1 2019, 9:37 PM
ngraham added a subscriber: ngraham.
ngraham added inline comments.
mobile/app/package/contents/ui/Thumbnails.qml
21

This will bump the Qt dependency to 5.12, which is not necessary for any changes in this patch.

mobile/app/package/contents/ui/ThumbnailsBase.qml
21
  1. Please only bump to 2.0, not 2.5 (see above comment for the reason)
  2. Does this actually work? Every time I've ported anything with a ScrollView from QQC1 to QQC2, the ScrollView part has needed extensive work. Can you make sure all functionality works--especially anything related to the scroll view? E.g. does it actually become scrollable if you resize the window to be very small?
mobile/app/package/contents/ui/TreeDelegate.qml
21

Ditto

mobile/components/DocumentView.qml
21 ↗(On Diff #50630)

Ditto

31 ↗(On Diff #50630)

Ditto

This revision now requires changes to proceed.Feb 1 2019, 9:37 PM
ognarb updated this revision to Diff 50677.Feb 1 2019, 10:28 PM

Revert some change

ngraham added inline comments.Feb 1 2019, 10:31 PM
mobile/app/package/contents/ui/ThumbnailsBase.qml
21

I meant, this can go up 2.0, just not 2.5.

ognarb added a comment.Feb 1 2019, 10:31 PM

So I tried to test ScrollView on my computer with a small display, on it look like it's working. But I prefer to revert this change, and reapply the change concerning ScrollView latter, after testing with my android phone with multitouch support.

ognarb added a comment.Feb 1 2019, 10:33 PM

Let's focus with this patch on fixing the depredations and the small bug only.

ognarb updated this revision to Diff 50678.Feb 1 2019, 10:35 PM
ognarb marked an inline comment as done.

I mean 1.3 and not 1.2 :)

ngraham accepted this revision.Feb 1 2019, 11:06 PM
This revision is now accepted and ready to land.Feb 1 2019, 11:06 PM
Closed by commit R223:2d568acd7d5f: Update some files to QQC2 and fix minor bug (authored by ognarb). · Explain WhyFeb 1 2019, 11:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50683

View Options

mobile/app/package/contents/ui/Thumbnails.qml

Loading...
View Options

mobile/app/package/contents/ui/ThumbnailsBase.qml

Loading...
View Options

mobile/app/package/contents/ui/TreeDelegate.qml

Loading...