Differential D18617

AsciiDoc: Fix highlighting of include directive
ClosedPublic
Actions

Authored by andreasgr on Jan 30 2019, 2:34 PM.

Details

Reviewers

dhaumann

Group Reviewers

Framework: Syntax Highlighting

Commits

R216:ab0b36345229: AsciiDoc: Fix highlighting of include directive

Summary

The include directive is always processed, even when within verbatim or passthrough blocks.
It should therefore be highlighted in these cases too.

Fix the highlighting definition asciidoc.xml.
Adjust and improve test file asciidoc.adoc.
Update created .fold, .html and .ref files.

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

andreasgr created this revision.Jan 30 2019, 2:34 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 30 2019, 2:34 PM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

andreasgr requested review of this revision.Jan 30 2019, 2:34 PM

Looks good to me. Please increase the "version" number whenever you change an highlighting file.

This revision is now accepted and ready to land.Jan 30 2019, 9:38 PM

Closed by commit R216:ab0b36345229: AsciiDoc: Fix highlighting of include directive (authored by dhaumann). · Explain WhyJan 30 2019, 9:41 PM

This revision was automatically updated to reflect the committed changes.

In D18617#402600, @dhaumann wrote:

Looks good to me. Please increase the "version" number whenever you change an highlighting file.

Ooops, sorry.
Many thanks for the quick review.

Revision Contents
Changeset List

			Path	Packages
M			autotests/folding/asciidoc.adoc.fold (59 lines)
M			autotests/html/asciidoc.adoc.html (61 lines)
M			autotests/input/asciidoc.adoc (59 lines)
M			autotests/reference/asciidoc.adoc.ref (61 lines)
M			data/syntax/asciidoc.xml (9 lines)