Differential D1861

Fix name of QDialogButtonBox's enumerator "StandardButtons"
ClosedPublic
Actions

Authored by aspotashev on Jun 14 2016, 10:19 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R317:3c451a98179e: Fix name of QDialogButtonBox's enumerator "StandardButtons"
Test Plan

The "krossqtstest qtstest.es" autotest works again.

Diff Detail

Branch
fix-enum-standard-buttons
Lint
No Linters Available
Unit
No Unit Test Coverage
aspotashev updated this revision to Diff 4441.Jun 14 2016, 10:19 AM
aspotashev retitled this revision from to Fix name of QDialogButtonBox's enumerator "StandardButtons".
aspotashev updated this object.
aspotashev edited the test plan for this revision. (Show Details)
aacid added a subscriber: aacid.Jun 14 2016, 10:35 PM

Is it me or phabricator doesn't say for which repo this patch is for?

bcooksley added a subscriber: bcooksley.Jun 15 2016, 7:53 AM

This review was posted without reference to the repository it belongs to - something Phabricator allows you to do.
Hence the lack of reference to the repository it is linked to.

dfaure accepted this revision.Jul 2 2016, 10:28 AM
dfaure added a reviewer: dfaure.
dfaure added a subscriber: dfaure.

(lack of repo) --> I now understand (from Ben) that this means phabricator isn't ready yet for being used for KF5 reviews. Let's use reviewboard for now (for new requests -- no need to move requests already created on phabricator).

Anyhow this is for Kross, clearly, and the patch looks sensible ;)

This revision is now accepted and ready to land.Jul 2 2016, 10:28 AM
aspotashev closed this revision.Jul 2 2016, 11:31 AM

Revision Contents
Changeset List

PathPackages
Msrc/modules/form.cpp (8 lines)

Diff 4441

View Options

src/modules/form.cpp

Loading...