Various minor cleanups in Kross
ClosedPublic

Authored by aspotashev on Jun 14 2016, 10:42 AM.

Details

Summary
  • Remove language-specific tests
  • loadLibrary: Make warning message more human-readable
  • Move CMake code generating .h files into respective directories
  • Do not unnecessarily link to KF5::ConfigCore

Diff Detail

Branch
cleanups-1
Lint
No Linters Available
Unit
No Unit Test Coverage
aspotashev updated this revision to Diff 4443.Jun 14 2016, 10:42 AM
aspotashev retitled this revision from to Various minor cleanups in Kross.
aspotashev updated this object.
aspotashev edited the test plan for this revision. (Show Details)
aspotashev updated this revision to Diff 4444.Jun 14 2016, 10:44 AM

rebased on top of D1861

dfaure accepted this revision.Jul 2 2016, 10:30 AM
dfaure added a reviewer: dfaure.
dfaure added a subscriber: dfaure.
dfaure added inline comments.
src/ui/CMakeLists.txt
9

Why doesn't this use ecm_generate_headers, BTW?

This revision is now accepted and ready to land.Jul 2 2016, 10:30 AM
aspotashev added inline comments.Jul 2 2016, 11:28 AM
src/ui/CMakeLists.txt
9

No reason, just because it's very old code. Will add it to my TODO list.

BTW, don't forget about today's garbage collection day
https://pp.vk.me/c636817/v636817971/13dcd/zjJVi_do1kQ.jpg

aspotashev closed this revision.Jul 2 2016, 11:32 AM