Changes in the menus
ClosedPublic

Authored by karinapassos on Jan 28 2019, 4:01 PM.

Details

Reviewers
tcanabrava
apol
Group Reviewers
KDE Edu
Summary

The calculator/2d menu/3d menu was wasting so much space, and didn't look good.

The menus are now organized in two: settings and file.

File has the options save, and loading options, also,
The save shortcut triggers the calculator save log, save 2d or save 3d based on in which tab you are (calculator, 2D or 3D)
This also applies now for the reset view, that reset the currently selected tab.
Removed the 'clear calculator' option from the menu and moved it to it's own space inside of a Layout

Diff Detail

Repository
R325 KAlgebra
Branch
addQmlFiles
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7991
Build 8009: arc lint + arc unit
karinapassos created this revision.Jan 28 2019, 4:01 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 28 2019, 4:01 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
karinapassos requested review of this revision.Jan 28 2019, 4:01 PM
karinapassos updated this revision to Diff 50438.EditedJan 28 2019, 4:12 PM

Removing an unneeded include.

tcanabrava edited the summary of this revision. (Show Details)Jan 28 2019, 4:21 PM
tcanabrava requested changes to this revision.Jan 28 2019, 4:24 PM
tcanabrava added inline comments.
src/kalgebra.cpp
160–161

please use the translation functions here. it's' the i18n call.

516

remove this empty space

520

here too

This revision now requires changes to proceed.Jan 28 2019, 4:24 PM
karinapassos edited the summary of this revision. (Show Details)Jan 28 2019, 4:24 PM
karinapassos updated this revision to Diff 50442.EditedJan 28 2019, 4:28 PM
karinapassos edited the summary of this revision. (Show Details)
  • The code with the requested changes.
tcanabrava accepted this revision.Jan 28 2019, 5:09 PM

@apol can you also check here?

This revision is now accepted and ready to land.Jan 28 2019, 5:09 PM
apol added a comment.Jan 29 2019, 2:36 PM

Can you show screenshots about it? I'm not sure I understand why you are doing this.

karinapassos marked 3 inline comments as done.EditedJan 29 2019, 4:11 PM
In D18585#401727, @apol wrote:

Can you show screenshots about it? I'm not sure I understand why you are doing this.

Sorry about the phone photos, i can't take a screenshot of the menus when they're open.
So, the change is because the calculator menu, 2d menu, etc... was on the main bar, and that only would be used when you were on that tab.
I thought there's no need to be on main bar a situational thing. I tried to make something more generic and waste less space.

apol added a comment.Jan 29 2019, 5:44 PM

I'm sorry, I don't really see it.

@karinapassos do you think it would make sense to schedule a call to discuss what changes would be useful to have? Or otherwise, why don't you send me an e-mail with your plans?

Apol,

Let me interfeer a bit.

The old menu scheme looked like tabs (because of the oddly disabled pipe
character on it.

I also agree with karina that those changes makes kalgebra look more
streamlined with the rest of kde.

Also, a call is a good thing. Let’s do this Friday?

Em ter, 29 de jan de 2019 às 18:44, Aleix Pol Gonzalez <
noreply@phabricator.kde.org> escreveu:

apol added a comment. View Revision https://phabricator.kde.org/D18585

I'm sorry, I don't really see it.

@karinapassos https://phabricator.kde.org/p/karinapassos/ do you think
it would make sense to schedule a call to discuss what changes would be
useful to have? Or otherwise, why don't you send me an e-mail with your
plans?

*REPOSITORY*
R325 KAlgebra

*BRANCH*
iniciarPreferencias

*REVISION DETAIL*
https://phabricator.kde.org/D18585

*To: *karinapassos, KDE Edu, tcanabrava, apol
*Cc: *kde-edu, narvaez, apol

apol added a comment.Jan 29 2019, 7:17 PM

This friday is impossible for me, as I'll be going to FOSDEM. Thursday (i.e. at around 5pm CET would work best for me).

In D18585#401853, @apol wrote:

I'm sorry, I don't really see it.

@karinapassos do you think it would make sense to schedule a call to discuss what changes would be useful to have? Or otherwise, why don't you send me an e-mail with your plans?

No problem. What's your e-mail adress?
About the call, no problem for me too.
Until friday, i'm available.

  • Change in plugins/CMakeLists.txt
karinapassos closed this revision.Feb 7 2019, 6:24 PM