Make XdgTest spec compliant
ClosedPublic

Authored by davidedmundson on Jan 28 2019, 10:56 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R127:818e0d1fcb65: Make XdgTest spec compliant
Summary

Right now it worked in kwin, but was in fact breaking the spec sending
buffers before it was configured.

There also seems to be an unclearly written (but very very sensible)
rule about comitting the surface after initial properties in order to
recieve the configure event.

After these changes it works in Weston too.

Test Plan

Ran test in kwin_wayland and weston

Diff Detail

Repository
R127 KWayland
Branch
master
Lint
Lint SkippedExcuse: lint is broken
Unit
No Unit Test Coverage
Build Status
Buildable 7616
Build 7634: arc lint + arc unit
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 28 2019, 10:56 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 28 2019, 10:56 AM
zzag added a subscriber: zzag.Jan 28 2019, 11:20 AM
zzag added inline comments.
tests/xdgtest.cpp
124

Q_UNUSED(size)
Q_UNUSED(states)

129

I had to use QStringLiteral to make it compile.

zzag accepted this revision.Jan 28 2019, 11:23 AM
This revision is now accepted and ready to land.Jan 28 2019, 11:23 AM
This revision was automatically updated to reflect the committed changes.