[Desktop Toolbox] Use a clearer name when the label is shown
ClosedPublic

Authored by ngraham on Fri, Jan 25, 3:22 PM.

Details

Summary

When the Desktop Toolbox is dragged out of a corner, its label is shown. Currently this label is not very clear since it consists only of the name of the current activity, which by default is "Default".

This patch introduces three changes:

  • When the label is shown, always prepend it with the widget's actual name: "Desktop Toolbox"
  • Append the word "Activity" so it's obvious what the preceding string refers to
  • Don't show the activity name if it's "Default" since this signifies that the user does not use Activities and would be confused by seeing references to a "Default Activity".
Test Plan

There are no visible changes to the default appearance; the Desktop Toolbox still has no label when it's in a corner. When dragged out of the corner, here's how it looks with this patch:

When using the Default activity:

When using differently-named activity:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Fri, Jan 25, 3:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Jan 25, 3:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Fri, Jan 25, 3:22 PM
ngraham edited the summary of this revision. (Show Details)Fri, Jan 25, 3:28 PM
ngraham edited the test plan for this revision. (Show Details)
hein accepted this revision.Fri, Jan 25, 3:36 PM
This revision is now accepted and ready to land.Fri, Jan 25, 3:36 PM
GB_2 added a subscriber: GB_2.Fri, Jan 25, 3:41 PM

Looks good!

toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
30

I think we should use this dash "—" instead of "-" for consistency.

ngraham updated this revision to Diff 50270.Fri, Jan 25, 4:20 PM

Use an emdash

ngraham marked an inline comment as done.Fri, Jan 25, 4:21 PM
GB_2 accepted this revision.Fri, Jan 25, 4:27 PM
This revision was automatically updated to reflect the committed changes.