| ngraham | |
| mart |
| Plasma |
When a theme doesn't supply background contrast values, we take an educated guess based on whether it's a dark or light theme. We didn't update the values when switching only color schemes at runtime (when theme follows it).
This lead to washed out Plasma popup and panel backgrounds. Instead, compute the fallback value at runtime
Also, while at it, update complimentary colorscheme as well, which was forgotten here.
BUG: 401142
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/plasma/private/theme_p.cpp | ||
|---|---|---|
| 730–731 | An alternative approach would be to store those values and then do the default fallback and qGray(color(Plasma::Theme::BackgroundColor).rgb()) < 127 stuff on the fly on demand. | |
| src/plasma/private/theme_p.cpp | ||
|---|---|---|
| 730–731 | but it wouldn't be guaranteed to be the same of the value stored in the config file no? | |
| src/plasma/private/theme_p.cpp | ||
|---|---|---|
| 730–731 | If the theme does not supply background contrast values, they are auto-determined from the background color (dark or light), or what do you mean? | |
| src/plasma/private/theme_p.cpp | ||
|---|---|---|
| 730–731 | They can be supplied from the theme too (or used to be) even though most of the themes don't | |
| src/plasma/private/theme_p.cpp | ||
|---|---|---|
| 730–731 | err, forget everything i said, i misunderstood your comment :) | |