Differential D18402

Use semantically correct restoration icon
ClosedPublic
Actions

Authored by shubham on Jan 20 2019, 4:16 AM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R260:f250b413cac2: Use semantically correct restoration icon
Test Plan

Before:


After:

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shubham created this revision.Jan 20 2019, 4:16 AM
Restricted Application added a project: Gwenview. · View Herald TranscriptJan 20 2019, 4:16 AM
shubham requested review of this revision.Jan 20 2019, 4:16 AM
shubham edited the test plan for this revision. (Show Details)Jan 20 2019, 4:16 AM
ngraham added a reviewer: VDG.Jan 20 2019, 5:24 PM

Hmm, I'm not sure about this. edit-undo isn't really that semantically incorrect since restoring a trashed item can be considered a form of undo. Also from a practical perspective, the edit-undo icon is far more meaningful than this restoration icon, whose meaning is not at all clear.

Let's see what the rest of VDG has to say.

ngraham accepted this revision.Jan 20 2019, 5:32 PM

Hmm.

Sounds like we need to fix that icon. We'll do that in the breeze-icons repo.

This revision is now accepted and ready to land.Jan 20 2019, 5:32 PM
Closed by commit R260:f250b413cac2: Use semantically correct restoration icon (authored by shubham). · Explain WhyJan 20 2019, 5:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/fileopscontextmanageritem.cpp (2 lines)

Diff 49951

View Options

app/fileopscontextmanageritem.cpp

Loading...