Differential D18397

Fix crash on canceling the file open dialog
ClosedPublic
Actions

Authored by vkrause on Jan 19 2019, 8:09 PM.

Details

Reviewers
apol
nicolasfella
aacid
Commits
R223:dfe6f26c6af8: Fix crash on canceling the file open dialog

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jan 19 2019, 8:09 PM
Restricted Application added a project: Okular. · View Herald TranscriptJan 19 2019, 8:09 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
vkrause requested review of this revision.Jan 19 2019, 8:09 PM
nicolasfella added a subscriber: nicolasfella.Jan 19 2019, 8:58 PM

I think the "proper" thing to do would be to check whether the resultCode is Activity.RESULT_OK or Activity.RESULT_CANCELED

aacid added a subscriber: apol.Jan 19 2019, 9:03 PM
apol accepted this revision.Jan 27 2019, 4:24 AM
This revision is now accepted and ready to land.Jan 27 2019, 4:24 AM
vkrause updated this revision to Diff 50371.Jan 27 2019, 10:36 AM

Check result code as suggested by Nico.

nicolasfella accepted this revision.Jan 27 2019, 12:31 PM
aacid accepted this revision.Feb 2 2019, 3:19 PM
Closed by commit R223:dfe6f26c6af8: Fix crash on canceling the file open dialog (authored by vkrause). · Explain WhyFeb 4 2019, 5:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50866

View Options

mobile/android/src/OpenFileActivity.java

Loading...