Details
Details
- Reviewers
dhaumann - Commits
- R294:d5e76df55828: Build without D-Bus on Android
Diff Detail
Diff Detail
- Repository
- R294 KBookmarks
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks good to me.
You likely get a warning about an unused variable now in KBookmarkManager::init(const QString &dbusPath), since the function is empty.
Comment Actions
Yep (and same for the other frameworks). I don't expect this to be the final state though, it's a first step to get things building without the D-Bus stub on Android at all, and get an overview of the gaps. Some cases will need a proper Android implementation, some might end up being mere porting aids that make no sense on Android.