Differential D18338

Add libvlc to elisa
ClosedPublic
Actions

Authored by jnosie on Jan 17 2019, 9:27 PM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R256:b0e718dd979c: Add libvlc to elisa
Summary

Adds libvlc to the elisa flatpak to handle playback.

BUG: 403076

Diff Detail

Repository
R256 Flatpak packaging for KDE Applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jnosie requested review of this revision.Jan 17 2019, 9:27 PM
jnosie created this revision.
mgallien added a comment.Jan 18 2019, 5:00 PM

I am currently trying to understand why I cannot build flatpak packages on my development system. I will review your patch once this is fixed. Sorry

mgallien accepted this revision.Jan 18 2019, 9:57 PM

Thanks a lot. It works fine. I had always thought that would require more work.

This revision is now accepted and ready to land.Jan 18 2019, 9:57 PM
mgallien added a comment.Jan 20 2019, 7:52 PM
In D18338#396123, @mgallien wrote:

Thanks a lot. It works fine. I had always thought that would require more work.

I forgot to ask if you have a KDE developer account ?
In case not, I will land the patch for you. In this case, I need your authorship information (name and email address).

jnosie added a comment.EditedJan 21 2019, 2:01 AM
In D18338#397154, @mgallien wrote:
In D18338#396123, @mgallien wrote:

Thanks a lot. It works fine. I had always thought that would require more work.

I forgot to ask if you have a KDE developer account ?
In case not, I will land the patch for you. In this case, I need your authorship information (name and email address).

I don't.
Name: Joseph Nosie
Email: joenosie at protonmail dot com

Closed by commit R256:b0e718dd979c: Add libvlc to elisa (authored by jnosie, committed by mgallien). · Explain WhyJan 21 2019, 8:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.elisa.json (12 lines)

Diff 50023

View Options

org.kde.elisa.json

Loading...