Differential D18308

Ignore all non-storage deviceAdded signals from Solid
ClosedPublic
Actions

Authored by bruns on Jan 17 2019, 5:17 AM.

Details

Reviewers
ngraham
broulik
Group Reviewers
Baloo
Frameworks
Commits
R293:c0b57ee70ea2: Ignore all non-storage deviceAdded signals from Solid
Summary

createCacheEntry is also called from SolidDeviceNotifier::deviceAdded,
which issues signals for all kinds of devices.

Ignore any events but for Solid::StorageAccess devices. This also avoids
trying to connect() to a nullptr.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Jan 17 2019, 5:17 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJan 17 2019, 5:17 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jan 17 2019, 5:17 AM
broulik accepted this revision.Jan 17 2019, 9:51 AM
broulik added a subscriber: broulik.
broulik added inline comments.
src/file/storagedevices.cpp
73

I think you can also move this check up

This revision is now accepted and ready to land.Jan 17 2019, 9:51 AM
bruns marked an inline comment as done.Jan 17 2019, 2:29 PM
bruns added inline comments.
src/file/storagedevices.cpp
73

yes, especially as it is the most trivial check ...

Closed by commit R293:c0b57ee70ea2: Ignore all non-storage deviceAdded signals from Solid (authored by bruns). · Explain WhyJan 17 2019, 2:55 PM
This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Msrc/file/storagedevices.cpp (8 lines)

Diff 49724

View Options

src/file/storagedevices.cpp

Loading...