Differential D18283

Auto-expand all tree elements in the side panel when the panel is first shown
AbandonedPublic
Actions

Authored by joaonetto on Jan 15 2019, 11:04 PM.

Details

Reviewers
None
Maniphest Tasks
T8553: Improve review side panel
Summary

When document is open, all the reviews are expanded in full form

Bug:

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7152
Build 7170: arc lint + arc unit
joaonetto requested review of this revision.Jan 15 2019, 11:04 PM
joaonetto created this revision.
aacid added a subscriber: aacid.Jan 15 2019, 11:07 PM
aacid added inline comments.
conf/okular.kcfg
309 ↗(On Diff #49586)

This seems to have sneaked form a different changeset.

joaonetto added a comment.Jan 15 2019, 11:08 PM

Fixing it, other files went in.

joaonetto updated this revision to Diff 49587.Jan 15 2019, 11:12 PM

Updated files

aacid added a subscriber: simgunz.Jan 16 2019, 9:43 PM

@simgunz can you explain why you wanted this in?

Is this really an improvement in usage? I mean if you have only 3 reviews, i guess yes, but if you have 1000 over 500 pages you may prefer it to not be expanded?

simgunz added a comment.Jan 17 2019, 8:27 AM

I use the side review panel only when I need to go through all the reviews one by one, so it is annoying having to expand all the elements by hand. Maybe a expand/collapse all solution would be a better solution. (The long answer is in T8553 ).

joaonetto abandoned this revision.Jan 18 2019, 1:05 PM

As discussed in T8553, a button that does this would be more suitable.

Revision Contents
Changeset List

PathPackages
Mpart.cpp (1 line)
Mui/side_reviews.h (1 line)
Mui/side_reviews.cpp (5 lines)

Diff 49587

View Options

part.cpp

Loading...
View Options

ui/side_reviews.h

Loading...
View Options

ui/side_reviews.cpp

Loading...