Differential D18277

Add a new preferences-desktop-theme-global icon
ClosedPublic
Actions

Authored by trickyricky26 on Jan 15 2019, 7:33 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R266:8523d32b1411: Add a new preferences-desktop-theme-global icon
Summary

Add a new preferences-desktop-theme-global icon for the Look and Feel / Global Theme KCM.

I also used svgcleaner on the original preferences-desktop-theme.

Test Plan

The new preferences-desktop-theme-global icon:


At 100%:

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trickyricky26 created this revision.Jan 15 2019, 7:33 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 15 2019, 7:33 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Jan 15 2019, 7:33 PM
trickyricky26 edited the summary of this revision. (Show Details)Jan 15 2019, 7:36 PM
trickyricky26 edited the test plan for this revision. (Show Details)
trickyricky26 added a reviewer: VDG.
ngraham retitled this revision from Add a new preference-desktop-theme icon, rename the old one to Add a new preferences-desktop-theme icon, rename the old one.Jan 15 2019, 7:38 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
ngraham added a subscriber: ngraham.Jan 15 2019, 7:44 PM

Just so you know, there are a lot of users for preferences-desktop-theme: https://lxr.kde.org/search?_filestring=&_string=preferences-desktop-theme

It's always good to do a search like this before you change the meaning of existing icons--even ones that are named poorly like this one.

I wonder if might be a better idea to leave the existing icon alone and create a new one rather than changing the meaning of preferences-desktop-theme.

ngraham added a comment.Jan 15 2019, 7:48 PM

Recommendation:

  • In this patch, just create a new LnF/Global theme icon with a new name. Maybe preferences-desktop-global-theme?
  • I rename preferences-desktop-theme to preferences-desktop-application-theme and put a compatibility symlink in place
  • Over time, we port all existing users of preferences-desktop-theme to use preferences-desktop-application-theme instead
  • Once there are no more users, we delete the compatibility symlink for preferences-desktop-theme

Thoughts?

trickyricky26 planned changes to this revision.Jan 15 2019, 8:04 PM
In D18277#393868, @ngraham wrote:

Recommendation:

  • In this patch, just create a new LnF/Global theme icon with a new name. Maybe preferences-desktop-global-theme?
  • I rename preferences-desktop-theme to preferences-desktop-application-theme and put a compatibility symlink in place
  • Over time, we port all existing users of preferences-desktop-theme to use preferences-desktop-application-theme instead
  • Once there are no more users, we delete the compatibility symlink for preferences-desktop-theme

    Thoughts?

Sure, I just chose the naming from a suggestion in the chat. I will update the diff with the new icon called preferences-desktop-global-theme.

trickyricky26 updated this revision to Diff 49565.Jan 15 2019, 8:22 PM
  • Revert renaming of old icon; name the new icon preferences-desktop-global-theme
trickyricky26 edited the summary of this revision. (Show Details)Jan 15 2019, 8:23 PM
trickyricky26 edited the test plan for this revision. (Show Details)
ngraham added a comment.Jan 15 2019, 8:26 PM

Actually now that I think about it, the name preferences-desktop-theme-global might be better because then if the icon doesn't exist, it will fall back to preferences-desktop-theme (which does exist) instead of preferences-desktop-global (which doesn't).

trickyricky26 updated this revision to Diff 49573.Jan 15 2019, 8:59 PM
  • Change name to preferences-desktop-theme-global
trickyricky26 retitled this revision from Add a new preferences-desktop-theme icon, rename the old one to Add a new preferences-desktop-theme-global icon.Jan 15 2019, 9:01 PM
trickyricky26 edited the summary of this revision. (Show Details)
trickyricky26 edited the test plan for this revision. (Show Details)
trickyricky26 planned changes to this revision.Jan 15 2019, 9:04 PM

I will make a variant with a titlebar that is split between a light and dark variant (like preferences-desktop-theme) as well as the bottom panel in the same style.

trickyricky26 updated this revision to Diff 49907.Jan 19 2019, 9:50 PM
  • Use a design with a rainbow background and color-split panel
trickyricky26 edited the summary of this revision. (Show Details)Jan 19 2019, 9:51 PM
trickyricky26 edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Jan 20 2019, 3:16 AM

😍😍

This revision is now accepted and ready to land.Jan 20 2019, 3:16 AM
Closed by commit R266:8523d32b1411: Add a new preferences-desktop-theme-global icon (authored by trickyricky26, committed by ngraham). · Explain WhyJan 20 2019, 3:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 49913

View Options

icons-dark/preferences/32/preferences-desktop-theme-global.svg

Loading...
View Options

icons-dark/preferences/32/preferences-desktop-theme.svg

Loading...
View Options

icons/preferences/32/preferences-desktop-theme-global.svg

Loading...
View Options

icons/preferences/32/preferences-desktop-theme.svg

Loading...