[CopyJob] Provide more descriptive notification header
Needs RevisionPublic

Authored by chinmoyr on Jan 15 2019, 1:46 PM.

Details

Reviewers
dfaure
broulik
Summary

A job can internally set a more descriptive title or a generic title will be provided for
the notification applet.

Diff Detail

Repository
R241 KIO
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7120
Build 7138: arc lint + arc unit
chinmoyr created this revision.Jan 15 2019, 1:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 15 2019, 1:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
chinmoyr requested review of this revision.Jan 15 2019, 1:46 PM

Isn't that done by emitCopying et al?

They emit a generic message. A descriptive message can only generated from within job.

dfaure requested changes to this revision.Mar 2 2019, 11:48 PM
dfaure added inline comments.
src/core/copyjob.cpp
344

translators won't know what to do with this word puzzle. Better do

const QString str = m_mode == CopyJob::Copy ? i18n("Copying %1 to %2") : i18n("Moving %1 to %2");
src/core/job.cpp
123

You can't make this static, otherwise the very first job will determine what all subsequent jobs will get in s_title.

And then remove the s_ prefix, of course.

(*3)

This revision now requires changes to proceed.Mar 2 2019, 11:48 PM