autotests/exiv2extractortest.cpp
61	move this up, as it is not specific to this test case
64	although only copied, I think it should be written like the other two: `QCOMPARE(result.properties().value(PhotoGpsAltiitude).toDouble(), 12.2);`

astippich marked an inline comment as done.Jan 13 2019, 11:23 AM

astippich added inline comments.

autotests/exiv2extractortest.cpp
64	That's not possible, qFuzzyCompare does not handle this correctly with a too small epsilon. It's probably because of the float->double conversion in the extractor

astippich retitled this revision from test empty and zero gps data to Test empty and zero gps data.Jan 13 2019, 11:24 AM

autotests/exiv2extractortest.cpp
64	see comment in the other review

This revision is now accepted and ready to land.Jan 18 2019, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
M			autotests/exiv2extractortest.h (1 line)
M			autotests/exiv2extractortest.cpp (33 lines)
A	M	(bin)	autotests/samplefiles/test_no_gps.jpg
A	M	(bin)	autotests/samplefiles/test_zero_gps.jpg

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49316	b6fa5f7		Jan 12 2019, 10:40 AM	★	★
Diff 2	49377	b6fa5f7	- move namespace	Jan 13 2019, 11:22 AM	★	★
Diff 3	49749	b6fa5f7	- update	Jan 17 2019, 7:33 PM	★	★
Diff 4	50078	7527819	R286:15d8c42d8ce0ebe58293a3af50726ef4b2c17c39	Jan 22 2019, 6:23 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
bd0c1fda9b34	f9e77b9d6eb7	b812b32b0158	Alexander Stippich	update	Jan 17 2019, 7:30 PM
b812b32b0158	3c523ba9d535	64bab43207bc	Alexander Stippich	move namespace	Jan 13 2019, 11:22 AM
64bab43207bc	8e692c2dc58f	b6fa5f7245fb	Alexander Stippich	test empty and zero gps data (Show More…)	Jan 10 2019, 7:56 AM