Differential D18159

Fix patch to not delete defualt activity
ClosedPublic
Actions

Authored by davidedmundson on Jan 10 2019, 4:23 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R119:ae8483efa40f: [Activities KCM] Fix patch to not delete default activity
R119:c382d7f27648: Merge branch 'Plasma/5.12'
Summary

Patch referenced an id which didn't exist
BUG: 397887

Test Plan

Had one activity, was disabled
Had two, both were enabled

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6916
Build 6934: arc lint + arc unit
davidedmundson created this revision.Jan 10 2019, 4:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 10 2019, 4:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 10 2019, 4:23 PM
ngraham accepted this revision.Jan 10 2019, 4:28 PM
ngraham added a subscriber: ngraham.

So sorry for this! I swear I tested this and it worked for me somehow. I even have a screenshot to prove it: https://i.imgur.com/kD5praI.png

The bad commit went into the Plasma/5.12 branch so please land there and do the merge dance.

This revision is now accepted and ready to land.Jan 10 2019, 4:28 PM
Closed by commit R119:ae8483efa40f: [Activities KCM] Fix patch to not delete default activity (authored by davidedmundson). · Explain WhyJan 10 2019, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 49169

View Options

kcms/activities/qml/activitiesTab/ActivitiesView.qml

Loading...