Fix patch to not delete defualt activity
ClosedPublic
Actions

Authored by davidedmundson on Jan 10 2019, 4:23 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Patch referenced an id which didn't exist
BUG: 397887

Test Plan

Had one activity, was disabled
Had two, both were enabled

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson requested review of this revision.Jan 10 2019, 4:23 PM

So sorry for this! I swear I tested this and it worked for me somehow. I even have a screenshot to prove it: https://i.imgur.com/kD5praI.png

The bad commit went into the Plasma/5.12 branch so please land there and do the merge dance.

This revision is now accepted and ready to land.Jan 10 2019, 4:28 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kcms/activities/qml/activitiesTab/ActivitiesView.qml (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49169	ced6236		Jan 10 2019, 4:23 PM	★	★
Diff 2	49172	eafb350	R119:ae8483efa40f4d47b3143405f0757a7edc126984	Jan 10 2019, 4:29 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d1a03e978b52	0e2aa78a3c63	ced62362743e	David Edmundson	Fix patch to not delete defualt activity (Show More…)	Jan 10 2019, 4:22 PM