Unbreak the AboutPage layout on smaller devices
ClosedPublic

Authored by leinir on Thu, Jan 10, 10:29 AM.

Details

Summary

Without this patch, if the about page is scaled down past a certain width (common on smaller phones and whatnot, easily reproduced on a desktop by simply making your window a bit small), the layout engine will enter an infinite (or near as makes no difference) loop.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Thu, Jan 10, 10:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptThu, Jan 10, 10:29 AM
leinir requested review of this revision.Thu, Jan 10, 10:29 AM
apol added a comment.Thu, Jan 10, 12:53 PM

Can you show a screenshot of before/after so I understand? So far it looks a bit random.

In D18150#390493, @apol wrote:

Can you show a screenshot of before/after so I understand? So far it looks a bit random.

Well, the previous state was "crash" so i /could/ take a shot of an empty desktop or a backtrace? ;) But also, sure, here's some screenshots...

the app in these shots is a non-KDE (but GPLv3) Kirigami app currently in development but as yet unreleased :) This is a shot of the "current version crashes" situation:

apol accepted this revision.Thu, Jan 10, 2:27 PM
This revision is now accepted and ready to land.Thu, Jan 10, 2:27 PM
This revision was automatically updated to reflect the committed changes.