Initial FreeBSD support for wayland.
- Based on the diff here: https://reviews.freebsd.org/differential/diff/52600/ by Greg V <greg@unrelenting.technology> .
Details
Details
- Reviewers
tcberner - Group Reviewers
Automotive KWin FreeBSD
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- Plasma/5.14
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6697 Build 6715: arc lint + arc unit
Comment Actions
I'm not sure whether KWin should carry this patch. No developer will be able to test it or ensure it works. It makes changes more difficult, it basically turns this into a don't touch me area.
Comment Actions
For the Udev case I would prefer if FreeBSD would provide a shim udev KWin can link against and which provides the hack deviceFromSyspath("/dev/dri/card0");
I really don't think KWin should break the Udev code path for differences in the platforms. If Udev cannot be used, then we don't use udev. But we don't fake udev inside our udev integration code.
| CMakeLists.txt | ||
|---|---|---|
| 278 | If this is FreeBSD specific it should be indicated so. Don't list it as an optional feature on platforms not affected. Please check whether it's needed and then turn it into a required feature on FreeBSD. | |
| 528 | and if epoll becomes a required feature on FreeBSD we can remove this check here. No need to keep the special if for freebsd. | |
| virtual_terminal.cpp | ||
| 88 | why is that linux specific? | |
| 105–109 | this I would prefer if it goes through a configure file, so that we don't need the ifdef in code. | |