Differential D17973

[Android] Fail more gracefully when building with API < 23
ClosedPublic
Actions

Authored by nicolasfella on Jan 4 2019, 11:53 PM.

Details

Reviewers
vkrause
apol
Commits
R289:0430c577f963: [Android] Fail more gracefully when building with API < 23
Summary

Building the Android backend with SDK < 23 is successful but fails at runtime because the jar is not found. Instead of just not including the jar when < 23 don't include the backend at all.

Test Plan

Itinerary now doesn't crash at startup

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jan 4 2019, 11:53 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 4 2019, 11:53 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jan 4 2019, 11:53 PM
apol accepted this revision.Jan 5 2019, 5:02 AM

we need a test app...

This revision is now accepted and ready to land.Jan 5 2019, 5:02 AM
vkrause accepted this revision.Jan 5 2019, 10:31 AM
Closed by commit R289:0430c577f963: [Android] Fail more gracefully when building with API < 23 (authored by nicolasfella). · Explain WhyJan 5 2019, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (6 lines)
Msrc/knotificationmanager.cpp (2 lines)

Diff 48737

View Options

src/CMakeLists.txt

Loading...
View Options

src/knotificationmanager.cpp

Loading...