Differential D17854

Search for notfication event configuration in qrc resources
ClosedPublic
Actions

Authored by vkrause on Dec 29 2018, 3:23 PM.

Details

Reviewers
cullmann
Commits
R289:aec9d7a29c80: Search for notfication event configuration in qrc resources
Summary

Simplifies deployment, and is particularly needed on
Android, which has no concept of shared data or configuration
files.

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Dec 29 2018, 3:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 29 2018, 3:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Dec 29 2018, 3:23 PM
cullmann added a subscriber: cullmann.Jan 6 2019, 12:45 PM

Would it make sense to put the files in some :/org.kde.knotifications/config folder to avoid clashs with other resources, like we do for syntax-highlighting?

Otherwise I think this is a good idea.

vkrause added a comment.Jan 6 2019, 1:03 PM
In D17854#387474, @cullmann wrote:

Would it make sense to put the files in some :/org.kde.knotifications/config folder to avoid clashs with other resources, like we do for syntax-highlighting?

Otherwise I think this is a good idea.

Yep, not very visible in this code, but that's actually happening, "filename" is prefixed with "knotifications5/" here.

cullmann accepted this revision.Jan 6 2019, 1:06 PM

Ok, then I would say: ship it.

This revision is now accepted and ready to land.Jan 6 2019, 1:06 PM
Closed by commit R289:aec9d7a29c80: Search for notfication event configuration in qrc resources (authored by vkrause). · Explain WhyJan 7 2019, 5:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/knotifyconfig.cpp (4 lines)

Diff 48874

View Options

src/knotifyconfig.cpp

Loading...