Add device icons for RJ11 and RJ45 ports
ClosedPublic

Authored by ndavis on Dec 28 2018, 8:39 PM.

Details

Test Plan

Breeze


Breeze Dark

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Dec 28 2018, 8:39 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 28 2018, 8:39 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Dec 28 2018, 8:39 PM
ndavis edited the test plan for this revision. (Show Details)Dec 28 2018, 8:40 PM
ndavis edited the test plan for this revision. (Show Details)

I love the full-color versions! For the monochrome ones, what do you think about putting them within a rounded rectangular frame like the full-color versions do? Right now the "femaleness" of the monochrome icons is not communicated as well as I think it could be; to me they look more like plugs than ports.

I love the full-color versions! For the monochrome ones, what do you think about putting them within a rounded rectangular frame like the full-color versions do? Right now the "femaleness" of the monochrome icons is not communicated as well as I think it could be; to me they look more like plugs than ports.

You mean like this?

To be honest, it's going to be a lot harder to create a good male version regardless of what the female version looks like. I only included the -female part because it's more accurate than just rj* and it at least leaves the option of implementing male versions, if that ever becomes necessary.

You mean like this?

Yeah, I like that much better!

Making the female version more femaley should hopefully make it easier to produce a contrasting male version later, should that ever be required.

ndavis updated this revision to Diff 48321.Dec 28 2018, 9:39 PM

Update style

ndavis edited the test plan for this revision. (Show Details)Dec 28 2018, 9:40 PM
ngraham accepted this revision.Dec 28 2018, 9:50 PM

Shipit!

This revision is now accepted and ready to land.Dec 28 2018, 9:50 PM
This revision was automatically updated to reflect the committed changes.